Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instances for the indexed TypeRep (+ Module) #83

Closed
wants to merge 1 commit into from

Conversation

goldfirere
Copy link

Fixes #82, along with a bonus instance.

@mixphix
Copy link
Collaborator

mixphix commented May 3, 2022

This fails on 8.0.2, presumably because that module didn't exist on that GHC version. I'm hesitant to drop support just for this patch, is there a way around it?

@goldfirere
Copy link
Author

Is some CPP allowed?

@mixphix
Copy link
Collaborator

mixphix commented May 3, 2022

I don't see why not; there's plenty of workarounds already.

mixphix pushed a commit that referenced this pull request Aug 26, 2022
add CPP to fix CI for 8.0.2

fix cpp for Type.Reflection
@mixphix
Copy link
Collaborator

mixphix commented Aug 26, 2022

I implemented these changes in 8215dcb, and fixed the failing CI for 8.0.2.

@mixphix mixphix closed this Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add instance for the indexed TypeRep from Type.Reflection
2 participants